feat: add toggle to send only the user's dictation prompt without the forced base prompt by mvanhorn · Pull Request #464 · altic-dev/FluidVoice

mvanhorn · 2026-06-28T23:01:03Z

Description

Adds a sendCustomPromptOnly toggle so AI Enhancement sends only the user's custom dictation prompt, without the forced base prompt prepended. This matches the "yolo toggle" approach @grohith327 endorsed on the issue: the resolution point is SettingsStore's prompt composition, routed through a new systemPrompt(forCustomProfileBody:mode:) helper. Default behavior is unchanged; the base prompt is only dropped when the toggle is on.

Adds request-body tests covering both toggle states.

Type of Change

Related Issue or Discussion

Closes #307

Testing

Tested on Intel Mac
Tested on Apple Silicon Mac
Tested on macOS version: 26.3
Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (0 violations)
Ran formatter locally: swiftformat --config .swiftformat Sources (files touched by this PR are clean; remaining repo-wide drift is pre-existing)
Ran tests locally: request-body tests for both toggle states are included in the PR; the suite runs in CI

Screenshots / Video

The new toggle in AI Enhancement > Advanced Prompts:

Off (default, unchanged behavior):

On:

Notes

The toggle only affects custom Dictate prompts; the built-in default prompt path is untouched. Built and ran this branch locally on Apple Silicon to capture the screenshots above.

… forced base prompt

chatgpt-codex-connector

💡 Codex Review

FluidVoice/Sources/Fluid/UI/AISettingsView+AdvancedSettings.swift

Lines 1749 to 1751 in 7d02784

    
           if enabled { 
        
               let combined = self.viewModel.combinedDraftPrompt(self.viewModel.draftPromptText, mode: self.viewModel.draftPromptMode) 
        
               self.promptTest.activate(draftPromptText: combined)

Apply the custom-only toggle in prompt test mode

When test mode is enabled from a Dictate prompt editor, the draft prompt is still passed through combinedDraftPrompt, which always prepends the built-in base prompt and does not consult sendCustomPromptOnly. With the new toggle on, the test request therefore exercises a different prompt than the one this setting is meant to send, so users can get misleading test output before saving or using the prompt.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-28T23:06:54Z

+        if normalizedMode == .dictate, self.sendCustomPromptOnly {
+            return trimmedBody


Honor custom-only prompts on the recording path

When a user enables this toggle and selects a custom Dictate prompt for the primary or secondary shortcut, the live recording path never reaches this new helper: applyDictationShortcutSelectionContext builds promptModeOverrideText with SettingsStore.combineBasePrompt(...) (ContentView.swift:3399-3402), and processTextWithAI prefers that non-empty overrideSystemPrompt before calling buildSystemPrompt (ContentView.swift:1819-1822). In that common selected-profile scenario, the built-in base prompt is still prepended even though sendCustomPromptOnly is true, so the advertised feature only works for paths that resolve through SettingsStore directly, such as app-bound profiles.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-06-28T23:06:54Z

+    var sendCustomPromptOnly: Bool {
+        get { self.defaults.bool(forKey: Keys.sendCustomPromptOnly) }
+        set {
+            objectWillChange.send()
+            self.defaults.set(newValue, forKey: Keys.sendCustomPromptOnly)


Preserve custom-only prompt setting in backups

This new persisted setting is not included in SettingsBackupPayload/settingsBackupPayload() and restore(from:) never reads it back, so exporting and importing a backup silently resets the toggle to the default false. For users who rely on custom-only Dictate prompts, a restored machine will start prepending the built-in base prompt again even though their prompt profiles and selections were restored.

Useful? React with 👍 / 👎.

grohith327 · 2026-07-10T01:51:09Z

@mvanhorn Can you update the PR description in the new template and also add screenshots/video for testing

mvanhorn · 2026-07-10T18:25:12Z

Done - the description now follows the PR template, and I added before/after screenshots of the new Send Custom Prompt Only toggle in the AI Enhancement > Advanced Prompts pane (built and ran the branch locally on macOS 26.3 to capture them).

grohith327 · 2026-07-11T20:07:30Z

@greptileai review

greptile-apps · 2026-07-11T20:12:51Z

Greptile Summary

This PR adds a sendCustomPromptOnly toggle to AI Enhancement that, when enabled, sends only the user's custom Dictate prompt without prepending the built-in base dictation prompt. Default behavior is unchanged; the base prompt is still prepended unless the toggle is explicitly turned on.

Adds sendCustomPromptOnly to SettingsStore and a private systemPrompt(forCustomProfileBody:mode:) helper that gates the base-prompt composition, correctly wired into all named-profile and app-binding code paths in promptResolution and effectiveDictationSystemPrompt.
Adds the toggle row to the Advanced Prompts routing-scope section for Dictate mode, and adds a read-only base-prompt reference panel in the prompt editor for context.
Adds four integration tests covering toggle-on, toggle-off, built-in default unchanged, and per-app binding behavior.

Confidence Score: 4/5

Safe to merge; the core toggle logic is correctly implemented across all user-facing prompt paths.

The new helper is wired into every named-profile and app-binding path. The one gap is the defaultDictationPromptOverride branch in defaultPromptResolution, which still calls combineBasePrompt directly, so a backup-restored prompt override silently ignores the toggle. This path is not exposed through the UI and is unlikely to affect users in practice, but the inconsistency is real.

SettingsStore.swift — specifically the defaultDictationPromptOverride branch inside defaultPromptResolution where it constructs the PromptResolution with a hard-coded combineBasePrompt call.

Comments Outside Diff (1)

Sources/Fluid/Persistence/SettingsStore.swift, line 1178-1185 (link)

The defaultDictationPromptOverride path in defaultPromptResolution still calls Self.combineBasePrompt directly instead of the new systemPrompt(forCustomProfileBody:mode:) helper. If a user's backup contains a defaultDictationPromptOverride and they enable sendCustomPromptOnly, that override will still have the base prompt prepended — inconsistently with how named profiles behave through the same toggle.

Prompt To Fix With AI

This is a comment left during a code review.
Path: Sources/Fluid/Persistence/SettingsStore.swift
Line: 1178-1185

Comment:
The `defaultDictationPromptOverride` path in `defaultPromptResolution` still calls `Self.combineBasePrompt` directly instead of the new `systemPrompt(forCustomProfileBody:mode:)` helper. If a user's backup contains a `defaultDictationPromptOverride` and they enable `sendCustomPromptOnly`, that override will still have the base prompt prepended — inconsistently with how named profiles behave through the same toggle.



How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Sources/Fluid/Persistence/SettingsStore.swift:1178-1185
The `defaultDictationPromptOverride` path in `defaultPromptResolution` still calls `Self.combineBasePrompt` directly instead of the new `systemPrompt(forCustomProfileBody:mode:)` helper. If a user's backup contains a `defaultDictationPromptOverride` and they enable `sendCustomPromptOnly`, that override will still have the base prompt prepended — inconsistently with how named profiles behave through the same toggle.

```suggestion
            let body = Self.stripBasePrompt(for: mode, from: trimmedOverride)
            return PromptResolution(
                source: source,
                profile: nil,
                appBinding: appBinding,
                promptBody: body,
                systemPrompt: self.systemPrompt(forCustomProfileBody: body, mode: mode)
            )
```

_{Reviews (1): Last reviewed commit: "feat: add toggle to send only the user's..." | Re-trigger Greptile}

grohith327

LGTM!

feat: add toggle to send only the user's dictation prompt without the…

7d02784

… forced base prompt

mvanhorn mentioned this pull request Jun 28, 2026

[🐞 BUG] Static dictation prompt for AI Enhancements sent with user's added prompt #307

Closed

chatgpt-codex-connector Bot reviewed Jun 28, 2026

View reviewed changes

grohith327 approved these changes Jul 11, 2026

View reviewed changes

grohith327 merged commit 58ed8df into altic-dev:main Jul 11, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add toggle to send only the user's dictation prompt without the forced base prompt#464

feat: add toggle to send only the user's dictation prompt without the forced base prompt#464
grohith327 merged 1 commit into
altic-dev:mainfrom
mvanhorn:fix/307-dictation-prompt-override-toggle

mvanhorn commented Jun 28, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 28, 2026

Uh oh!

chatgpt-codex-connector Bot Jun 28, 2026

Uh oh!

grohith327 commented Jul 10, 2026

Uh oh!

mvanhorn commented Jul 10, 2026

Uh oh!

grohith327 commented Jul 11, 2026

Uh oh!

greptile-apps Bot commented Jul 11, 2026 •

edited

Loading

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

grohith327 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if enabled {
	let combined = self.viewModel.combinedDraftPrompt(self.viewModel.draftPromptText, mode: self.viewModel.draftPromptMode)
	self.promptTest.activate(draftPromptText: combined)

		if normalizedMode == .dictate, self.sendCustomPromptOnly {
		return trimmedBody

Uh oh!

Conversation

mvanhorn commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Related Issue or Discussion

Testing

Screenshots / Video

Notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

grohith327 commented Jul 10, 2026

Uh oh!

mvanhorn commented Jul 10, 2026

Uh oh!

grohith327 commented Jul 11, 2026

Uh oh!

greptile-apps Bot commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

grohith327 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mvanhorn commented Jun 28, 2026 •

edited

Loading

greptile-apps Bot commented Jul 11, 2026 •

edited

Loading